From fe7a369d3948d32760c6b40c4526cc0732d88b43 Mon Sep 17 00:00:00 2001 From: Bushilei Date: Wed, 19 Apr 2023 17:05:36 +0800 Subject: [PATCH 1/3] fix memory leak Signed-off-by: Bushilei --- apps/shell/src/shcmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/shell/src/shcmd.c b/apps/shell/src/shcmd.c index e51dee3d..ac1a701a 100644 --- a/apps/shell/src/shcmd.c +++ b/apps/shell/src/shcmd.c @@ -533,6 +533,8 @@ void OsShellCmdPush(const char *string, CmdKeyLink *cmdKeyLink) SH_ListTailInsert(&(cmdKeyLink->list), &(cmdNewNode->list)); + free(cmdNewNode); + return; } -- Gitee From f32e8b42f791b80ef4dc2be8ffe29cce4a4e6ea4 Mon Sep 17 00:00:00 2001 From: bushilei Date: Fri, 21 Apr 2023 08:56:44 +0000 Subject: [PATCH 2/3] update apps/shell/src/shcmd.c. Signed-off-by: bushilei --- apps/shell/src/shcmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/shell/src/shcmd.c b/apps/shell/src/shcmd.c index ac1a701a..b01ccb79 100644 --- a/apps/shell/src/shcmd.c +++ b/apps/shell/src/shcmd.c @@ -294,6 +294,7 @@ static void OsCompleteStr(char *result, const char *target, char *cmdKey, unsign *des++ = *src++; (*len)++; } + return; } static int OsExecNameMatch(const char *strPath, const char *nameLooking, char *strObj, unsigned int *maxLen) @@ -508,6 +509,7 @@ void OsShellKeyDeInit(CmdKeyLink *cmdKeyLink) cmdKeyLink->count = 0; free(cmdKeyLink); + return; } void OsShellCmdPush(const char *string, CmdKeyLink *cmdKeyLink) -- Gitee From ad3bb3b9bb5d23aabebf304a2b8c0746dbf5249a Mon Sep 17 00:00:00 2001 From: bushilei Date: Fri, 21 Apr 2023 09:07:14 +0000 Subject: [PATCH 3/3] update apps/shell/src/shcmd.c. Signed-off-by: bushilei --- apps/shell/src/shcmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/shell/src/shcmd.c b/apps/shell/src/shcmd.c index b01ccb79..ce722363 100644 --- a/apps/shell/src/shcmd.c +++ b/apps/shell/src/shcmd.c @@ -48,6 +48,7 @@ static void OsFreeCmdPara(CmdParsed *cmdParsed) cmdParsed->paramArray[i] = NULL; } } + return; } static int OsStrSeparateTabStrGet(const char **tabStr, CmdParsed *parsed, unsigned int tabStrLen) -- Gitee