From 6e7db1b5defcad160c4a5012e2a1f2c413ff6b60 Mon Sep 17 00:00:00 2001 From: rita_dong Date: Tue, 15 Sep 2020 11:29:28 +0800 Subject: [PATCH 1/2] add pr check special word, add learning materials --- README.en.md | 11 ++++++++++- README.md | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/README.en.md b/README.en.md index 049e86d..7c08253 100644 --- a/README.en.md +++ b/README.en.md @@ -43,7 +43,16 @@ You are welcome to participate in the discussion of the issues and contribute to ### Notes on software packaging pull request checking 1. Check whether the automatic check program is passed, if not, it is not allowed to merge; -2. Understand the function of software and evaluate whether it belongs to Java-Packages, that is, it conforms to the scope of software that needs to be maintained in the above introduction. In case of doubt, you can discuss with other maintainers before deciding whether to allow merging. +2. Understand the function of software and evaluate whether it belongs to Java-Packages, that is, it conforms to the scope of software that needs to be maintained in the above introduction. In case of doubt, you can discuss with other maintainers before deciding whether to allow merging; +3. Note if there are special codes in the spec file, such as "fedora" or "rhel" information, click [here] [suspected_spec] to view the relevant issue, in case of this type of issue please confirm with the pr committers before deciding whether to allow merging. +### Learning materials + +1. [RPM Documentation][rpm_doc] +2. [Check scripts for information such as URL and source in spec file, check scripts for license file][spec_check_file] + +[rpm_doc](http://rpm.org/documentation) +[suspected_spec](https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue) +[spec_check_file](https://gitee.com/openeuler/Java-Packages/attach_files) diff --git a/README.md b/README.md index e2d07ed..9348eb6 100644 --- a/README.md +++ b/README.md @@ -44,6 +44,15 @@ ### 软件包提交PR审核注意事项 1. 检查门禁程序是否通过，不通过则不允许合并； -2. 了解软件包作用，评估是否应属于Java-Packages，即符合上述介绍中明确需要维护的软件包范围，如遇疑问，可与其他maintainer讨论软件包归属后再决定是否允许合并。 +2. 了解软件包作用，评估是否应属于Java-Packages，即符合上述介绍中明确需要维护的软件包范围，如遇疑问，可与其他maintainer讨论软件包归属后再决定是否允许合并； +3. 注意spec文件中是否存在特殊代码，如"fedora"或"rhel"等信息，可点击[这里][suspected_spec]查看相关issue，如遇此类问题请先与提交者确认后再决定是否允许合并。 +### 学习资料 + +1. [RPM Documentation][rpm_doc] +2. [spec文件中URL与source等check脚本，license文件check脚本][spec_check_file] + +[rpm_doc](http://rpm.org/documentation) +[suspected_spec](https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue) +[spec_check_file](https://gitee.com/openeuler/Java-Packages/attach_files) -- Gitee From 4424aa839f6ca5753c07f9453ca3731ad2640e12 Mon Sep 17 00:00:00 2001 From: rita_dong Date: Tue, 15 Sep 2020 11:36:17 +0800 Subject: [PATCH 2/2] modify link format --- README.en.md | 6 +++--- README.md | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.en.md b/README.en.md index 7c08253..b3c11d0 100644 --- a/README.en.md +++ b/README.en.md @@ -51,8 +51,8 @@ You are welcome to participate in the discussion of the issues and contribute to 1. [RPM Documentation][rpm_doc] 2. [Check scripts for information such as URL and source in spec file, check scripts for license file][spec_check_file] -[rpm_doc](http://rpm.org/documentation) -[suspected_spec](https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue) -[spec_check_file](https://gitee.com/openeuler/Java-Packages/attach_files) +[rpm_doc]: http://rpm.org/documentation +[suspected_spec]: https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue +[spec_check_file]: https://gitee.com/openeuler/Java-Packages/attach_files diff --git a/README.md b/README.md index 9348eb6..77ce851 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,7 @@ 1. [RPM Documentation][rpm_doc] 2. [spec文件中URL与source等check脚本，license文件check脚本][spec_check_file] -[rpm_doc](http://rpm.org/documentation) -[suspected_spec](https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue) -[spec_check_file](https://gitee.com/openeuler/Java-Packages/attach_files) +[rpm_doc]: http://rpm.org/documentation +[suspected_spec]: https://gitee.com/openeuler/Java-Packages/issues/I1UL4S?from=project-issue +[spec_check_file]: https://gitee.com/openeuler/Java-Packages/attach_files -- Gitee